Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: bump metrics-server to v0.4.4 #4424

Merged
merged 1 commit into from
May 19, 2021
Merged

chore: bump metrics-server to v0.4.4 #4424

merged 1 commit into from
May 19, 2021

Conversation

chewong
Copy link

@chewong chewong commented May 18, 2021

Signed-off-by: Ernest Wong chuwon@microsoft.com

Reason for Change:

Bump metrics-server to v0.4.4 for 1.22+ cluster to fix test failure in https://testgrid.k8s.io/sig-windows-master-release#aks-engine-windows-dockershim-serial-slow-master. Also reflecting changes introduced in https://github.com/kubernetes-sigs/metrics-server/pull/201/files.

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • No
  • Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • No
  • Yes

Requirements:

Notes:

@codecov
Copy link

codecov bot commented May 18, 2021 •
edited
Loading

Codecov Report

Merging #4424 (3a940d2) into master (60828c7) will increase coverage by 0.00%.
The diff coverage is 72.66%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #4424    +/-   ##
========================================
  Coverage   72.04%   72.05%            
========================================
  Files         141      141            
  Lines       21631    21764   +133     
========================================
+ Hits        15584    15681    +97     
- Misses       5096     5131    +35     
- Partials      951      952     +1
Impacted Files Coverage Δ
cmd/rotate_certs.go 11.03% <0.00%> (ø)
pkg/api/common/versions.go 96.37% <ø> (ø)
pkg/api/types.go 92.85% <ø> (ø)
pkg/api/vlabs/types.go 73.04% <ø> (ø)
pkg/engine/templates_generated.go 43.31% <ø> (ø)
pkg/engine/template_generator.go 66.37% <11.53%> (-2.17%) ⬇️
cmd/get_logs.go 49.57% <30.43%> (-1.79%) ⬇️
pkg/api/addons.go 98.01% <100.00%> (ø)
pkg/api/converterfromapi.go 95.71% <100.00%> (+<0.01%) ⬆️
pkg/api/convertertoapi.go 94.04% <100.00%> (+0.01%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90867d6...3a940d2. Read the comment docs.

jackfrancis
jackfrancis reviewed May 18, 2021
View reviewed changes
parts/k8s/addons/metrics-server.yaml Outdated
@@ -130,6 +130,17 @@ spec:
- /metrics-server
- --kubelet-insecure-tls
- --kubelet-preferred-address-types=InternalIP
- --cert-dir=/tmp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes back-compat to v0.3.7? (that's what all the k8s versions besides 1.22 are using)

@jackfrancis
Copy link
Member

I had tried unsuccessfully to update to 0.4.2 a while back, see:

#4270

I notice you haven't made as many changes as I had (if I remember correctly I was moving over stuff from the upstream example yaml spec that wasn't in the aks-engine spec)

@chewong
Copy link
Author

chewong commented May 18, 2021 •
edited
Loading

Didn't notice you have an opening PR to upgrade metrics-server. Let me rebase this off your branch and test

@jackfrancis
Copy link
Member

Didn't notice you have an opening PR to upgrade metrics-server. Let me rebase this off your branch and test

Well, except mine never worked. :)

@chewong
Copy link
Author

chewong commented May 18, 2021

looks like we need --kubelet-insecure-tls in the args, but it's for testing purposes only:

--kubelet-insecure-tls                                    Do not verify CA of serving certificates presented by Kubelets.  For testing purposes only.

@jackfrancis do you know if it's okay to use this flag?

@jsturtevant
Copy link
Contributor

@jackfrancis do you know if it's okay to use this flag?

I believe the deployment here has always had that flag.

Ideally I believe you would generate cert using https://kubernetes.io/docs/reference/access-authn-authz/certificate-signing-requests/ and then start the metric server with that cert

@jsturtevant jsturtevant mentioned this pull request May 19, 2021
Closed
chore: bump metrics-server to v0.4.4
3a940d2 
Signed-off-by: Ernest Wong <chuwon@microsoft.com>
@chewong chewong requested a review from jackfrancis May 19, 2021 15:51
jackfrancis
jackfrancis approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented May 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis jackfrancis merged commit e729cf8 into Azure:master May 19, 2021
@chewong chewong deleted the bump-metrics-server branch May 19, 2021 20:31
@pierluigilenoci
Copy link
Contributor

Just few days before the new release 😢
Ref: #4455

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jackfrancis jackfrancis jackfrancis approved these changes

@mboersma mboersma Awaiting requested review from mboersma

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chewong @jackfrancis @jsturtevant @acs-bot @pierluigilenoci